[Bug 466047] Review Request: tcl-mysqltcl - MySQL interface for Tcl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=466047


Paulo Roma Cavalcanti <roma at lcg.ufrj.br> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |roma at lcg.ufrj.br




--- Comment #1 from Paulo Roma Cavalcanti <roma at lcg.ufrj.br>  2008-10-29 12:43:12 EDT ---
Hi,

this is not an official review (practice review):


rpmlint outputs the following:

[lua:~/rhrpms] rpmlint tcl-mysqltcl-3.05-1.fc8.x86_64.rpm
tcl-mysqltcl.x86_64: W: no-version-in-last-changelog
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


[lua:~/rhrpms] rpmlint tcl-mysqltcl-debuginfo-3.05-1.fc8.x86_64.rpm
tcl-mysqltcl-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/mysqltcl-3.05/generic/mysqltcl.c
tcl-mysqltcl-debuginfo.x86_64: E: wrong-script-end-of-line-encoding
/usr/src/debug/mysqltcl-3.05/generic/mysqltcl.c
tcl-mysqltcl-debuginfo.x86_64: W: no-version-in-last-changelog
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

Therefore you need to:

1) add a version in the changelog section

%changelog
* Thu Oct 7 2008 Rene Ploetz <RenePloetz at gmx.de> 3.05-1
- Initial mysqltcl

2) remove the execution bit of mysqltcl.c in the %%prep section:

chmod -x generic/mysqltcl.c

3) You should not use

Requires:       tcl tcl(abi) = 8.5 mysql

F8 has tcl(abi) = 8.4, for instance, and mysql in not necessary,
because one of its shared libraries is a dependency anyway.

4) The license seems to be BSD and not MIT, but I did not check it yet.

[lua:~/temp/temp/mysqltcl-3.05] more COPYING 
Some other old historical license notes can be fond in
READMY-msqltcl , mysqltcl.c and mysqltcl.n

It seems that it is BSD-like licence

5) You should obsolete mysqltcl, in case someone is using an old package
named this way.

6) Add mysqltcl.html to the documentation.

7) Claim ownership of directory %{mysqltcl}-%{version}

8) My comments were based on:

https://fedoraproject.org/wiki/Packaging/ReviewGuidelines

This link should help you in the future.


I would suggest a spec like the one below. It builds cleanly in mock
for F8 and F9 i386 or x86_64:

mock -r fedora-8-i386 rebuild tcl-mysqltcl-3.05-2.fc8.src.rpm --define
"tcl_version 8.4"


---------------------------------------------------------------------------

# We used to define this dynamically, but the Fedora buildsystem chokes on
# using this for the versioned Requires on tcl(abi), so we hardcode it.
# This sucks, but there is no other clean way around it, because tcl
# (and tclsh) aren't in the default buildroot.
%{!?tcl_version: %define tcl_version 8.5}
%{!?tcl_sitearch: %define tcl_sitearch tcl%{tcl_version}}

%define real_name mysqltcl

Summary:        MySQL interface for Tcl
Name:           tcl-mysqltcl
Version:        3.05
Release:        2%{?dist}
License:        BSD
Group:          Development/Languages
Source:         http://www.xdobry.de/mysqltcl/%{real_name}-%{version}.tar.gz
URL:            http://www.xdobry.de/mysqltcl
BuildRequires:  mysql-devel
BuildRequires:  tcl-devel >= 8.3.1 
Requires:       tcl(abi) = %{tcl_version}
Buildroot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
Provides:       %{real_name} = %{version}-%{release}
Obsoletes:      %{real_name} < %{version}-%{release}

%description
Mysqltcl is an extension to the Tool Command Language (Tcl)
that provides high-level access to a MySQL database server.

%prep
%setup -q -n %{real_name}-%{version}
chmod -x generic/mysqltcl.c

%build
%configure --with-tcl=%{_libdir} \
           --with-mysql-lib=%{_libdir}/mysql \
           --enable-threads
make %{?_smp_mflags}

%install
rm -rf %{buildroot}
make install DESTDIR=%{buildroot}

pushd %{buildroot}%{_libdir}
mkdir %{tcl_sitearch}
mv %{real_name}-%{version} %{tcl_sitearch}
popd

%clean
rm -rf %{buildroot}

%files
%defattr(0644,root,root,0755)
%doc README README-msqltcl ChangeLog COPYING AUTHORS doc/mysqltcl.html
%defattr (-,root,root,-)
%{_libdir}/%{tcl_sitearch}/%{real_name}-%{version}
%{_mandir}/mann/*

%changelog
* Thu Oct 7 2008 Rene Ploetz <RenePloetz at gmx.de> 3.05-1
- Initial mysqltcl spec file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.