[Bug 462577] Review Request: hunspell-ur - Urdu hunspell dictionaries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=462577


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2008-09-17 05:55:34 EDT ---
+ Ok
- Needs Work

Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=829910
+ rpmlint is silent for SRPM 
- rpmlint is NOT silent for RPM.
hunspell-ur.noarch: E: zero-length /usr/share/doc/hunspell-ur-0.6/CREDITS
+ source files match upstream.
843cdc5094ca146c683d4f0441296ad2  UrduDictionary.xpi
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

Suggestion:-
  Change SPEC line from %build from
rdfproc hunspell-ur parse /usr/src/redhat/BUILD/hunspell-ur/install.rdf
to
rdfproc hunspell-ur parse install.rdf

This will avoid rpmlint message
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.