[Bug 426867] Review Request: scala - Hybrid functional/object-oriented language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=426867





--- Comment #62 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-09-03 13:10:34 EDT ---
Well, for 2.7.2-0.1.RC1:

* License
------------------------------------------
# Except src/scala/collection/immutable/Tree.scala which is LGPLv2+
------------------------------------------
  - This file is moved to src/library/scala/collection/immutable/Tree.scala,
    which says:
------------------------------------------
** NOTE: This code was until 2007-04-01 under a GPL license. The author has
** given permission to remove that license, so that now this code is under
** the general license for the Scala libraries. 
------------------------------------------
    So now the whole codes are under BSD.

* Binaries
  - In Source0:
------------------------------------------
./docs/examples/plugintemplate/lib/scalatest.jar: Zip archive data, at least
v1.0 to extract
./lib/ant/ant-contrib.jar:                        Zip archive data, at least
v1.0 to extract
./lib/ant/ant-dotnet-1.0.jar:                     Zip archive data, at least
v1.0 to extract
./lib/ant/vizant.jar:                             Zip archive data, at least
v1.0 to extract
./lib/cldcapi10.jar:                              Zip archive data, at least
v2.0 to extract
./lib/fjbg.jar:                                   Zip archive data, at least
v1.0 to extract
./lib/jline.jar:                                  Zip archive data, at least
v1.0 to extract
./lib/midpapi10.jar:                              Zip archive data, at least
v1.0 to extract
./lib/mscorlib.dll:                               PE32 executable for MS
Windows (DLL) (console) Intel 80386 32-bit Mono/.Net assem
bly
./lib/msil.jar:                                   Zip archive data, at least
v2.0 to extract
./lib/scala-compiler.jar:                         Zip archive data, at least
v1.0 to extract
./lib/scala-library-src.jar:                      Zip archive data, at least
v1.0 to extract
./lib/scala-library.jar:                          Zip archive data, at least
v1.0 to extract
./lib/scalaruntime.dll:                           PE32 executable for MS
Windows (DLL) (console) Intel 80386 32-bit Mono/.Net assem
bly
./test/diff/diff.exe:                             PE32 executable for MS
Windows (console) Intel 80386
./test/diff/libiconv2.dll:                        PE32 executable for MS
Windows (DLL) (console) Intel 80386
./test/diff/libintl3.dll:                         PE32 executable for MS
Windows (DLL) (console) Intel 80386
./test/files/jvm/libnatives-32.so:                ELF 32-bit LSB shared object,
Intel 80386, version 1 (SYSV), dynamically linked, 
not stripped
./test/files/jvm/libnatives-64.so:                ELF 64-bit LSB shared object,
x86-64, version 1 (SYSV), dynamically linked, not s
tripped
./test/files/jvm/libnatives.jnilib:               Mach-O dynamically linked
shared library i386
./test/files/jvm/natives-32.dll:                  PE32 executable for MS
Windows (DLL) (GUI) Intel 80386 32-bit
./test/files/lib/annotations.jar:                 Zip archive data, at least
v1.0 to extract
./test/files/lib/methvsfield.jar:                 Zip archive data, at least
v1.0 to extract
./test/files/lib/nest.jar:                        Zip archive data, at least
v2.0 to extract
------------------------------------------
    Among above, jar files are now correctly treated. Would you remove the else
    at %prep?

! BuildRequires
  - Current Java packaging guidelines says that all Java package must have
    "BuildRequires: java-devel, jpackage-utils".
    Although this is redundant as ant Requires both, would you add these
    BuildRequires?

* -apidoc subpackage
  - Current Java packaging guidelines
    https://fedoraproject.org/wiki/Packaging/Java
    says that 
    * apidocs subpackage must be named as "-javadoc".
    * All apidocs must be placed under %{_javadocdir}.

* %defattr
  - %defattr is not set on ant-scala subpackage.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.