[Bug 453026] Review Request: xmp - A multi-format module player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453026


Karol Trzcionka <karlikt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |karlikt at gmail.com
         AssignedTo|nobody at fedoraproject.org    |karlikt at gmail.com




--- Comment #5 from Karol Trzcionka <karlikt at gmail.com>  2008-09-05 09:45:47 EDT ---
Please add script to generate tarball according to
http://fedoraproject.org/wiki/Packaging/SourceURL#When_Upstream_uses_Prohibited_Code
but at now it is not a blocker.
others:
+ rpmlint returns only:
audacious-plugin-xmp.x86_64: W: no-documentation
xmms-xmp.x86_64: W: no-documentation
it might be ignored
+ naming is OK
+ specfile named correct
+ package meets Guidelines
+ License is correct (files which cannot be shipped by Fedora are removed)
+ License tag is ok
+ COPYING file correctly provided
+ I think it is American English
+ specfile is clear for me
+ tarball is changed, so I don't compare md5sum
+ building checked before on koji
+ N/A
+ compiled on koji fine, so I think BRs are correct
+ N/A
+ N/A
+ OK, using macros instead of hardcoded paths
+ correct own all files
+ there are no duplicates in %files
+ %defattr used
+ correct %clean section
+ macros are used correctly
+ nonfree file is removed
+ N/A
+ %doc doesn't affect the runtime of app
+ N/A
+ N/A
+ N/A
+ N/A
+ N/A
+ there are not any .la files
+ N/A
+ correct owns all files
+ correct %install section
+ RPMs have valid UTF-8 files

SHOULD Items:
+ N/A (license is included)
+ N/A (no translations)
+ chacked on koji by Charles
+ like above
? I cannot check working
+ N/A
? probably it is not needed to requires it with full version
+ N/A (no .pc files)
+ dependencies are correct

I can approve but change comment about removing a file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.