[Bug 461358] Review Request: weplab - Analyzing WEP encryption security on wireless networks

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461358


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at christoph-wickert.de




--- Comment #1 from Christoph Wickert <fedora at christoph-wickert.de>  2008-09-06 13:10:05 EDT ---
Some quick comments on your spec:

- license is GPLv2+. Take a look at the haeders of the source: "or (at your
option) any later version"

- remove INSTALL from %doc, it generic information that is not needed when
installed from rpm

- remove NEWS from %doc, it's empty

- the manpage should not have %doc

- mockbuild fails:
  checking for pcap_open_live in -lpcap... no
  ERROR: You need libpcap-dev!
So obviously this BuildRequires: libpcap-devel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.