[Bug 461393] Review Request: congruity - Application to program Logitech® Harmony® universal remote controls

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461393


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu




--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu>  2008-09-07 15:12:21 EDT ---
Since the included icon files have separate licensing and that licensing is
intact in the final built RPMs, you need to indicate the various licenses in
the package.  You should have at least "License: GPLv3+ and CC-BY-SA" with a
comment about which png file carries the separate license, but you should also
investigate the license of those icon-*.png files and see which GPL versions
they are under.  (The LICENSE.txt files doesn't specify.)  If they're not
GPLv3+ as well, then you'll need to indicate them in License, too.

A desktop file is required so that this package properly appears in the menus.

* source files match upstream:
   c43b3884e3d91e9a866be39bc6d3cc1452503cf5f89b5cac10065dd25b30525f  
   congruity-9.tar.bz2
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
X license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none).
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   congruity = 9-1.fc10
  =
   /usr/bin/python
   libconcord-python >= 0.20
   wxPython

* %check is not present; no test suite.  I installed and ran the program, but I 
   have neither the necessary remote nor a programming file for it.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
X GUI program, but no desktop file is installed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.