[Bug 461491] Review Request: xosview - OS resource viewer

bugzilla at redhat.com bugzilla at redhat.com
Mon Sep 8 16:54:33 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461491





--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-09-08 12:54:32 EDT ---
For 1.8.3-12.cvs:

* License
  - The license tag should be "GPL+". As far as I checked the
    whole codes I cannot find any notes which specifies the version
    to be "2 and any later".
    ! Note: If only GPLv2 text is put in, we interpret it as "GPL at
      any version" because of the section 9.

* Desktop file
  - "Terminal" value must be "false", not "0" (well, desktop-file-install
     warned this before, however current one does not...)
 
http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html#value-types

Other things are okay
-------------------------------------------------------------
      This package (xosview) is APPROVED by mtasaka
-------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list