[Bug 461097] Review Request: hunspell-gu - Gujarati hunspell dictionary

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461097


Caolan McNamara <caolanm at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |caolanm at redhat.com
         AssignedTo|nobody at fedoraproject.org    |caolanm at redhat.com




--- Comment #2 from Caolan McNamara <caolanm at redhat.com>  2008-09-09 04:26:48 EDT ---
+ MUST: rpmlint must be run on every package.
  no output

+ MUST: The package must be named according to the Package Naming Guidelines .
  dictionary versioning is tricky as they're generally messy, my own preference
is to treat date based releases like pre-releases i.e. hunspell-gu-0.20061015-1
rather than hunspell-gu-20061015-1, but that was clearly not a blocker for
hunspell-bn or hunspell-hi so shouldn't be here either.


+ MUST: The spec file name must match the base package %{name}
  yup

+ MUST: The package must meet the Packaging Guidelines .
  yup

+ MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
  yup

+ MUST: The License field in the package spec file must match the actual
license.
  yup

+ MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
  yup

+ MUST: The spec file must be written in American English.
  yup

+ MUST: The spec file for the package MUST be legible.
  yup

+ MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
  yup

+ MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
  yup

+ MUST: If the package does not successfully compile
  not-relevent

- MUST: All build dependencies must be listed in BuildRequires
  yup

+ MUST: The spec file MUST handle locales properly
  yup

- MUST: Every binary RPM package which stores shared library files
  not relevent

+ MUST: If the package is designed to be relocatable
  yup

+ MUST: A package must own all directories that it creates
  yup

+ MUST: A package must not contain any duplicate files in the %files listing.
  yup

+ MUST: Permissions on files must be set properly
  yup

+ MUST: Each package must have a %clean section
  yup

+ MUST: Each package must consistently use macros

+ MUST: The package must contain code, or permissable content
  yup

+ MUST: Large documentation files should go in a -doc subpackage.
  yup

+ MUST: If a package includes something as %doc, it must not affect the runtime
  yup

+ MUST: Header files must be in a -devel package.
  yup

+ MUST: Static libraries must be in a -static package.
  yup

+ MUST: Packages containing pkgconfig(.pc) files must ...
  yup

+ MUST: If a package contains library files with a suffix ...
  yup

+ MUST: In the vast majority of cases, devel packages must...
  yup

+ MUST: Packages must NOT contain any .la libtool archives
  yup

+ MUST: Packages containing GUI applications...
  yup

+ MUST: Packages must not own files or directories already owned by other
packages
  yup

+ MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
  yup


looks fine to me

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.