[Bug 226510] Merge Review: udev

Tue Sep 9 18:06:53 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=226510

--- Comment #5 from Jon Ciesla <limb at jcomserv.net>  2008-09-09 14:06:52 EDT ---
reviewed curret rawhide SRPM:

rpmlint on SRPM:

udev.src:328: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built.  Add default attributes using
%defattr before it in the %files section, or use per line %attr's.

udev.src:340: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built.  Add default attributes using
%defattr before it in the %files section, or use per line %attr's.

udev.src:344: E: files-attr-not-set
A file or a directory entry in a %files section does not have attributes set
which may result in security issues in the resulting binary package depending
on the system where the package is built.  Add default attributes using
%defattr before it in the %files section, or use per line %attr's.

udev.src: W: mixed-use-of-spaces-and-tabs (spaces: line 101, tab: line 136)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

on RPMS:

libudev0.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

libudev-devel.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

libudev-devel.i386: W: no-dependency-on libudev/libudev-libs/liblibudev
udev.i386: W: conffile-without-noreplace-flag /etc/modprobe.d/floppy-pnp
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: conffile-without-noreplace-flag /etc/udev/makedev.d/50-udev.nodes
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/40-alsa.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/40-alsa.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/40-redhat.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag /lib/udev/rules.d/40-redhat.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/50-udev-default.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/50-udev-default.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/60-cdrom_id.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/60-cdrom_id.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/60-persistent-input.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/60-persistent-input.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/60-persistent-storage-tape.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/60-persistent-storage-tape.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/60-persistent-storage.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/60-persistent-storage.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/60-persistent-v4l.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/60-persistent-v4l.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/61-persistent-storage-edd.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/61-persistent-storage-edd.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/64-device-mapper.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/64-device-mapper.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/64-md-raid.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/64-md-raid.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/75-cd-aliases-generator.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/75-cd-aliases-generator.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/75-persistent-net-generator.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/75-persistent-net-generator.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/79-fstab_import.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/79-fstab_import.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/80-drivers.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/80-drivers.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/95-pam-console.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/95-pam-console.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: non-etc-or-var-file-marked-as-conffile
/lib/udev/rules.d/95-udev-late.rules
A file not in /etc or /var is marked as being a configuration file. Please put
your conf files in /etc or /var.

udev.i386: W: conffile-without-noreplace-flag
/lib/udev/rules.d/95-udev-late.rules
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

udev.i386: W: dangerous-command-in-%trigger rm
udev.i386: W: dangerous-command-in-%trigger rm
udev.i386: W: service-default-enabled /etc/rc.d/init.d/udev-post
The service is enabled by default after "chkconfig --add"; for security
reasons, most services should not be. Use "-" as the default runlevel in the
init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword
to fix this if appropriate for this service.

udev.i386: W: service-default-enabled /etc/rc.d/init.d/udev-post
The service is enabled by default after "chkconfig --add"; for security
reasons, most services should not be. Use "-" as the default runlevel in the
init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword
to fix this if appropriate for this service.

udev.i386: W: incoherent-init-script-name udev-post
The init script name should be the same as the package name in lower case, or
one with 'd' appended if it invokes a process by that name.

See the above issues as well.

Working on a new mock build. . .

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.