[Bug 442377] Review Request: python-pysctp - Python binding for the SCTP network protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=442377


Rakesh Pandit <rakesh.pandit at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #7 from Rakesh Pandit <rakesh.pandit at gmail.com>  2008-09-10 02:37:22 EDT ---

APPROVED

Summary:
1. Fix changelog entry before importing
2. Please look at some details mentioned below before requesting for CVS and
importing

Required:

[!] rpmlint -- pasted above. Correctly fill the changelog entry
[x] Naming -- Okay, we already have package names like python-pydns
python-pyspf python-pycurl

    You can however keep pysctp also because it is an upstream name and is
treated as an exception in
python naming convention
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29 

It is your choice. But make this choice before requesting for CVS :)

[x] md5sum

Source downloaded from project hosting
[rpmbuild at rocky python]$ md5sum pysctp-0.3.1.tar.gz 
7fd43fa7a7f31cff557d0a69fa751e5f  pysctp-0.3.1.tar.gz

Source from srpm
[rpmbuild at rocky python-pysctp-0.3.1-2.fc8]$ md5sum pysctp-0.3.1.tar.gz 
7fd43fa7a7f31cff557d0a69fa751e5f  pysctp-0.3.1.tar.gz

Match

[x] %files section - includes all files

In spite of using {python_sitelib}/* you may consider using
{python_sitelib}/<modulename>/<regex> which is better option. This is optional
though, but what you are doing is bad practice. 

[x] license - fedora approved
[x] license field - matches actual license
[x] source does not have license file - may be requested upstream
[?] eggs -

Check whether eggs are handled correctly in F-8, you may like to have a look at 
https://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_for_non-setuptools_packages

My mock seems not working right now so could not check for f-8 specifically.
But it seems to me okay - looking at spec

[x] spec file legible and written in American English
[x] source URL correct
[x] Builds successfully on koji
[x] owns all directories created
[x] %makeinstall %clean rm -rf $RPM_BUILD_ROOT
[NA] dev, header file, static libs 


Optional suggestions:
[x] may be you could request upstream about including license file
[!] Description could be bit  better in my view.  

*You may like to ignore them*

Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.