[Bug 461818] Review Request: gears-backgrounds - Gears desktop backgrounds

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461818


Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tcallawa at redhat.com
         AssignedTo|nobody at fedoraproject.org    |tcallawa at redhat.com




--- Comment #1 from Tom "spot" Callaway <tcallawa at redhat.com>  2008-09-10 17:17:37 EDT ---
REVIEW
=======
Bad:

- Don't use "%{_prefix}/share", use "%{_datadir}" (you got it right in the
%files section)

Good:

- rpmlint checks return nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (CC-BY-SA) OK, text in %doc, matches source
- spec file legible, in am. english
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- content, OK
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Should Fix:
- Source tarball has no upstream URL location. You should really make a home
for it and reference the full URL in the spec.

Show me a fixed spec file with %{_datadir} used consistently and I'll approve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.