[Bug 461757] Review Request: libdwarf - library for producing and consuming DWARF debugging information

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461757


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com




--- Comment #3 from Parag AN(पराग) <panemade at gmail.com>  2008-09-11 03:33:56 EDT ---
Suggestions:-
1) you can altenatively use version as
%define upstreamid 20080818
Version: 0.%{upstreamid}
This will help you in future if you switch to releases like 1.0 or 1.0.0
otherwise you need to use always date as version.

2) You should use shared libraries scriptlet as per given here
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Shared_libraries

3) you should use "install -Dp" as per given here
http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps

4) Though not mandatory but good if you use defattr as
%defattr(-,root,root,-)
https://fedoraproject.org/wiki/PackageMaintainers/CreatingPackageHowTo#.25files_section

5) Package build is failed
http://koji.fedoraproject.org/koji/taskinfo?taskID=819456
   You should use make as
   make %{?_smp_mflags}  CFLAGS="$RPM_OPT_FLAGS -I."


Why you want to include -static package? See
http://fedoraproject.org/wiki/PackagingGuidelines#Packaging_Static_Libraries

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.