[Bug 452806] Review Request: ember-media - media files for the ember

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=452806


Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tcallawa at redhat.com
         AssignedTo|nobody at fedoraproject.org    |tcallawa at redhat.com
               Flag|                            |needinfo?




--- Comment #6 from Tom "spot" Callaway <tcallawa at redhat.com>  2008-09-11 15:39:58 EDT ---
I've attached a diff between your last spec file, and one I edited to fix the
rpmlint errors:

This review is against the fixed spec and SRPM. Please make those changes
before committing.

Good:

- rpmlint checks return:
ember-media.noarch: W: dangling-relative-symlink
/usr/share/ember/media/shared/common/themes/ember/gui/fonts/VeraBd.ttf
../../../../../../../../fonts/bitstream-vera/VeraBd.ttf
ember-media.noarch: W: dangling-relative-symlink
/usr/share/ember/media/shared/common/themes/ember/gui/fonts/Vera.ttf
../../../../../../../../fonts/bitstream-vera/Vera.ttf
ember-media.noarch: W: dangling-relative-symlink
/usr/share/ember/media/shared/core/Vera.ttf
../../../../fonts/bitstream-vera/Vera.ttf

These are safe to ignore, because you have Requires: bitstream-vera-fonts

- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2+ or GFDL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream (1bd54d49063505c63ea9f4548711749b7e75a553)
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- content okay
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Please be sure you make my changes before you commit, but this is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.