[Bug 461794] Review Request:0xFFFF - The Open Free Fiasco Firmware Flasher

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461794


manuel wolfshant <wolfy at nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro




--- Comment #3 from manuel wolfshant <wolfy at nobugconsulting.ro>  2008-09-13 20:04:15 EDT ---
In the build log I get:
cd src/gui && make all
make[1]: Entering directory `/builddir/build/BUILD/0xFFFF-0.3.9/src/gui'
gtkamlc --save-temps --Xcc=-I../squeue ../squeue/squeue.c ../fpid.c
../squeue/squeue.vapi gui.gtkaml extras
.vapi --pkg gtk+-2.0 -o goxf
make[1]: gtkamlc: Command not found
make[1]: *** [all] Error 127
make[1]: Leaving directory `/builddir/build/BUILD/0xFFFF-0.3.9/src/gui'
make[1]: Entering directory `/builddir/build/BUILD/0xFFFF-0.3.9/logotool'
cc -Wall -g   -c -o logotool.o logotool.c
make: [frontend] Error 2 (ignored)
cc -Wall -g   -c -o compress.o compress.c
cc -Wall -g   -c -o uncompress.o uncompress.c
cc -Wall -g   -c -o rgb2yuv.o rgb2yuv.c
uncompress.c: In function 'uncompress_image':
uncompress.c:74: warning: cast from pointer to integer of different size
uncompress.c:74: warning: cast from pointer to integer of different size
uncompress.c:108: warning: format '%d' expects type 'int', but argument 3 has
type 'long int'
cc logotool.o compress.o uncompress.o rgb2yuv.o -o logotool
make[1]: Leaving directory `/builddir/build/BUILD/0xFFFF-0.3.9/logotool'

Since you claim that you do not build the GUI, maybe the above could be skipped
?
Especially as a bit later in the build log we can see:
  cp logotool/logotool
/builddir/build/BUILDROOT/0xFFFF-0.3.9-1.fc10.x86_64/usr/bin
which you DO pack and include in the final rpm. Despite that logotool has not
been compiled using RPM_OPT_FLAGS

David, please fix the above and I'll happily approve the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.