[Bug 226033] Merge Review: libmng

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226033


Jon Ciesla <limb at jcomserv.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |limb at jcomserv.net
         AssignedTo|nobody at fedoraproject.org    |limb at jcomserv.net




--- Comment #1 from Jon Ciesla <limb at jcomserv.net>  2008-09-16 10:59:55 EDT ---
rpmlint on SRPM:

libmng.src: E: non-utf8-spec-file /tmp/libmng-1.0.9-7.src.rpm.15198/libmng.spec
The character encoding of the spec file is not UTF-8.  Convert it for example
using iconv(1).

libmng.src:41: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.

libmng.src: E: tag-not-utf8 %changelog
The character encoding of the value of this tag is not UTF-8.

rpmlint on RPMS:

libmng.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

libmng.i386: E: tag-not-utf8 %changelog
The character encoding of the value of this tag is not UTF-8.

libmng-debuginfo.i386: E: tag-not-utf8 %changelog
The character encoding of the value of this tag is not UTF-8.

libmng-devel.i386: E: tag-not-utf8 %changelog
The character encoding of the value of this tag is not UTF-8.


All pretty trivial, but should be fixed.

Source0 should change to: 
Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz

md5sum of provided source and that from upstream differ:
[limb at fawkes SPECS]$ md5sum libmng-1.0.7.tar.gz
863002cf13a60ccfd8be641b62e3cc58  libmng-1.0.7.tar.gz
[limb at fawkes SPECS]$ md5sum ../SOURCES/libmng-1.0.9.tar.gz
ff1205ef70855a75c098ea09690413c6  ../SOURCES/libmng-1.0.9.tar.gz

- MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
( or $RPM_BUILD_ROOT ). See  Prepping BuildRoot For %install for details.

Fix.

Mock build OK, so BuildRequires are fine.  No other blockers after full review,
so fix the above and we're set.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.