[Bug 441378] Review Request: smokeping - Latency Logging and Graphing System

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=441378





--- Comment #21 from manuel wolfshant <wolfy at nobugconsulting.ro>  2008-09-16 11:09:43 EDT ---
It looks better now, but I have found a few small issues. And I also have a
question about which I am not sure.
a) perl has become an useless BR, because it is brought in by perl(Grammar);
b) glibc-common is definitely not needed as BR;
c) you use lots of macros in the {__xx} form, but "mv" is used as such. Nor a
blocker neither incorrect, but not consistent from a stylish point of view.
d) in the lines
   %{__rm} -rf in lib/{CGI,Config,Digest,JSON}
   %{__rm} -rf in lib/{SNMP_Session,SNMP_util,BER,JSON}.pm

 I assume there is a confusion or a leftover from using find, as rm does not
need or use the "in" argument. rm -fR in lib/*.. does not fail because of the
-f flag, but you should remove the word "in" from these lines


Now the preamble of the question: as far as I can see, the newer rpm (2.4.2-3)
removed the requires for
 perl(B)
 perl(CGI::Session::Driver)
 perl(CGI::Session::Driver::DBI)
 perl(CGI::Session::ErrorHandler)
 perl(Class::Struct)
 perl(DBD::Pg)
 perl(DB_File)
 perl(DBI)
 perl(Digest::HMAC)
 perl(Digest::SHA1)
 perl(File::Spec)
 perl(FreezeThaw)
 perl(overload)
 perl(Scalar::Util)
 perl(Test::More)

I do not have the infrastructure on which to test and my perl-fu is rather
weak, so I have to rely to an answer from others: is all the previous
functionality preserved ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.