[Bug 428798] Review Request: OmegaT - Computer Aid Translation tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=428798





--- Comment #26 from Ismael Olea <ismael at olea.org>  2008-09-17 16:19:44 EDT ---
(In reply to comment #25)
> * License
>   - As far as I checked the source codes, License tag must
>     be "GPLv2+".

fixed

> * Dependency
>   - Currently omegat cannot be lauched (logs attached)
>     At least "Requires: vldocking" is needed (note: this is not
>     automatically added by rpmbuild)

fixed

> ! Unneeded directory
> ------------------------------------------------------------
> mkdir -p $RPM_BUILD_ROOT/%{_iconsdir}

fixed
> 
> * Macros
>   - Use macros for standard directories

fixed

> * Desktop file
>   - "X-Desktop-File-Install-Version" is automatically added by
>     desktop-file-install command, so this is not needed (and
>     on rawhide this is 0.15)

fixed


> * General rpmlint issue
> ------------------------------------------------------------
> OmegaT.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/OmegaT-1.7.3_03/readme_hu.txt

fixed

> OmegaT.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 7)

fixed

>   - I am not Java expert, however is manifest needed for OmageT jar file?

Well, me not too. I've been doing zillion test and this is only method I found
to let the application work.

Probably there is a more elegant method. I hope I'll learn it in the future.

http://olea.org/tmp/OmegaT.spec

http://olea.org/paquetes-rpm/fedora-9/OmegaT-1.7.3_03-4olea.src.rpm
http://olea.org/paquetes-rpm/fedora-9/OmegaT-1.7.3_03-4olea.noarch.rpm

Seems ready!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.