[Bug 461425] Review Request: daap-sharp - DAAP client library for Mono

bugzilla at redhat.com bugzilla at redhat.com
Mon Sep 22 17:12:20 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=461425





--- Comment #3 from Michel Alexandre Salim <michel.sylvan at gmail.com>  2008-09-22 13:12:19 EDT ---
Straightforward review, since the package has already been approved, so these
are just clean-up requests.

rpmlint:
daap-sharp.src: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 10)

Easiest fix is to open the file in Emacs, select all, then M-x untabify

Package builds OK, but on my system that has monodoc installed, it generates
some files that are currently unpackaged:

RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/lib64/monodoc/sources/daap-sharp-docs.source
   /usr/lib64/monodoc/sources/daap-sharp-docs.tree
   /usr/lib64/monodoc/sources/daap-sharp-docs.zip

These won't be generated by Koji since monodoc is not installed there, but
would you consider adding a BR and packaging them, perhaps in a -doc
subpackage?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list