[Bug 459878] Review Request: genome - Package for the Genome Project

Mon Sep 22 22:08:11 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=459878

--- Comment #5 from S.A. Hartsuiker <sahartsu at xs4all.nl>  2008-09-22 18:08:11 EDT ---
$ rpmlint -i genome-sync-1.1.2-1.fc9.noarch.rpm
genome-sync.noarch: W: obsolete-not-provided rubygem-genome-sync
If a package is obsoleted by a compatible replacement, the obsoleted package
must also be provided in order to provide clean upgrade paths and not cause
unnecessary dependency breakage.  If the obsoleting package is not a
compatible replacement for the old one, leave out the provides.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Done on purpose, to allow explicit cleaning out of all old packages (eg yum
remove rubygem-genome-*)

$ rpmlint -i genome-styling-1.1.2-1.fc9.noarch.rpm
genome-styling.noarch: W: non-conffile-in-etc
/etc/httpd/conf.d/genome-styling.conf
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

This should be fixed.

$ rpmlint -i genome-server-1.1.2-1.fc9.noarch.rpm
genome-server.noarch: W: non-conffile-in-etc /etc/httpd/conf.d/genomed.conf
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

This should be fixed.

genome-server.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/genomed-1.1.2/extra/genomed.redhat 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

Not sure if this is a problem?

genome-server.noarch: W: summary-not-capitalized daemon for Genome machine
configuration
Summary doesn't begin with a capital letter.

This should be fixed.

genome-server.noarch: W: obsolete-not-provided rubygem-genomed
If a package is obsoleted by a compatible replacement, the obsoleted package
must also be provided in order to provide clean upgrade paths and not cause
unnecessary dependency breakage.  If the obsoleting package is not a
compatible replacement for the old one, leave out the provides.

Done on purpose, see above.

genome-server.noarch: W: conffile-without-noreplace-flag
/etc/genomed/config.yml
A configuration file is stored in your package without the noreplace flag. A
way to resolve this is to put the following in your SPEC file:
%config(noreplace) /etc/your_config_file_here

This should be fixed.

genome-server.noarch: E: init-script-without-chkconfig-postin
/etc/init.d/genomed
The package contains an init script but doesn't contain a %post with a call to
chkconfig.

This should be fixed.

genome-server.noarch: E: init-script-without-chkconfig-preun
/etc/init.d/genomed
The package contains an init script but doesn't contain a %preun with a call
to chkconfig.

This should be fixed.

genome-server.noarch: W: service-default-enabled /etc/init.d/genomed
The service is enabled by default after "chkconfig --add"; for security
reasons, most services should not be. Use "-" as the default runlevel in the
init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword
to fix this if appropriate for this service.

Not sure about this?

genome-server.noarch: W: no-reload-entry /etc/init.d/genomed
In your init script (/etc/rc.d/init.d/your_file), you don't have a 'reload'
entry, which is necessary for good functionality.

Can this even have a reload option?

genome-server.noarch: E: subsys-not-used /etc/init.d/genomed
While your daemon is running, you have to put a lock file in
/var/lock/subsys/. To see an example, look at this directory on your machine
and examine the corresponding init scripts.

Contact upstream about this please.

genome-server.noarch: W: incoherent-init-script-name genomed
The init script name should be the same as the package name in lower case, or
one with 'd' appended if it invokes a process by that name.

1 packages and 0 specfiles checked; 4 errors, 7 warnings.

$ rpmlint -i genome-repo-1.1.2-1.fc9.noarch.rpm
genome-repo.noarch: W: service-default-enabled
/etc/init.d/genome-repo-bootstrap
The service is enabled by default after "chkconfig --add"; for security
reasons, most services should not be. Use "-" as the default runlevel in the
init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword
to fix this if appropriate for this service.

genome-repo.noarch: W: incoherent-init-script-name genome-repo-bootstrap
The init script name should be the same as the package name in lower case, or
one with 'd' appended if it invokes a process by that name.

1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint -i genome-release-1.1.2-1.fc9.noarch.rpm
genome-release.noarch: W: non-conffile-in-etc
/etc/pki/rpm-gpg/RPM-GPG-KEY-genome
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

This should be fixed.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint -i genome-firstboot-1.1.2-1.fc9.noarch.rpm
genome-firstboot.noarch: W: service-default-enabled
/etc/init.d/genome-firstboot
The service is enabled by default after "chkconfig --add"; for security
reasons, most services should not be. Use "-" as the default runlevel in the
init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword
to fix this if appropriate for this service.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint -i genome-dsl-1.1.2-1.fc9.noarch.rpm
genome-dsl.noarch: W: obsolete-not-provided rubygem-genome-dsl
If a package is obsoleted by a compatible replacement, the obsoleted package
must also be provided in order to provide clean upgrade paths and not cause
unnecessary dependency breakage.  If the obsoleting package is not a
compatible replacement for the old one, leave out the provides.

Again, done on purpose.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint -i genome-cloudmasterd-httpd-redirect-1.1.2-1.fc9.noarch.rpm
genome-cloudmasterd-httpd-redirect.noarch: W: obsolete-not-provided
httpd-redirect-cloudmasterd
If a package is obsoleted by a compatible replacement, the obsoleted package
must also be provided in order to provide clean upgrade paths and not cause
unnecessary dependency breakage.  If the obsoleting package is not a
compatible replacement for the old one, leave out the provides.

Again, done on purpose.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint -i genome-cloudmasterd-httpd-1.1.2-1.fc9.noarch.rpm
genome-cloudmasterd-httpd.noarch: W: obsolete-not-provided httpd-cloudmasterd
If a package is obsoleted by a compatible replacement, the obsoleted package
must also be provided in order to provide clean upgrade paths and not cause
unnecessary dependency breakage.  If the obsoleting package is not a
compatible replacement for the old one, leave out the provides.

Again, done on purpose.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint -i genome-cloudmasterd-1.1.2-1.fc9.noarch.rpm
genome-cloudmasterd.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/cloudmasterd-1.1.2/extra/cloudmasterd.init 0644
This text file contains a shebang or is located in a path dedicated for
executables, but lacks the executable bits and cannot thus be executed.  If
the file is meant to be an executable script, add the executable bits,
otherwise remove the shebang or move the file elsewhere.

This should be fixed.

genome-cloudmasterd.noarch: W: obsolete-not-provided rubygem-cloudmasterd
If a package is obsoleted by a compatible replacement, the obsoleted package
must also be provided in order to provide clean upgrade paths and not cause
unnecessary dependency breakage.  If the obsoleting package is not a
compatible replacement for the old one, leave out the provides.

Again, done on purpose.

genome-cloudmasterd.noarch: W: incoherent-init-script-name cloudmasterd
The init script name should be the same as the package name in lower case, or
one with 'd' appended if it invokes a process by that name.

This should be fixed.

1 packages and 0 specfiles checked; 1 errors, 2 warnings.

$ rpmlint -i genome-bootstrap-1.1.2-1.fc9.noarch.rpm
genome-bootstrap.noarch: W: obsolete-not-provided rubygem-genome-bootstrap
If a package is obsoleted by a compatible replacement, the obsoleted package
must also be provided in order to provide clean upgrade paths and not cause
unnecessary dependency breakage.  If the obsoleting package is not a
compatible replacement for the old one, leave out the provides.

Again, done on purpose.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint -i genome-autostarter-1.1.2-1.fc9.noarch.rpm
genome-autostarter.noarch: W: non-conffile-in-etc
/etc/cron.d/genome-autostarter
A non-executable file in your package is being installed in /etc, but is not a
configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

This should be fixed.

1 packages and 0 specfiles checked; 0 errors, 1 warnings.

Not exactly quiet is it?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.