[Bug 449037] Review Request: afio - cpio compatible archiver

bugzilla at redhat.com bugzilla at redhat.com
Thu Sep 25 21:03:15 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=449037





--- Comment #9 from Debarshi Ray <debarshi.ray at gmail.com>  2008-09-25 17:03:13 EDT ---
+ First of all, I think it would be better to skip the 2GB+ test case because
our buildsystem might not always have enough disk space to run it:
    [...]
    %check
    make regtest
    # make regtest2gb
    [...]
  I should have checked it earlier before asking you to turn it on. Sorry for
that.

+ The French translation of the %description stanza is still translating the
older description. Would be good to fix it.

+ Ideally the URL & Source0 combination ought to be:
    URL: http://freshmeat.net/projects/afio/
    Source0: http://freshmeat.net/redir/afio/144/url_tgz/%{name}-%{version}.tgz
  You did mention a tool to generate the package, but then why is it necessary
to rename the source tarball and change its URL. Without a valid reason, the
URL and Source0 fields in the Spec files should point to the upstream
home/project page and release tarball respectively.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list