[Bug 464424] Review Request: GROMACS - a Molecular Dynamics package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=464424





--- Comment #3 from Dominik 'Rathann' Mierzejewski <rpm at greysector.net>  2008-09-28 17:28:21 EDT ---
(In reply to comment #2)
> Oh, I had just looked in the requests and old packages, I hadn't noticed that
> you had tried making an RPM before.
> 
> I cleaned up the BuildRequires; it's true that they were a bit redundant.
> 
> Prelink is needed since I have to remove executable stacks from libraries.

That's a major hack. Does it even work after you do that? It's better to fix
the sources instead. I'd prefer it if you identified the problem at its source
instead of papering over it. It's probably in some assembly code that doesn't
define the .note.GNU-stack section. There are a lot of patches on the web to
remove executable stack requirements for various software (xvidcore, for
example). You might want to consult those.

> I changed -share to -common as suggested.
> 
> As I wrote now in the spec file the configures are done in the %install phase,
> since in order to get the {single,double}{,mpi} binaries you need to redo the
> configure and install phase 4 times. The beginning of the %install phase erases
> %buildroot.

No, you must keep the build process in %build. If you need several different
configurations, you can create subdirs in builddir and run configure with
different options and make there (it's called out-of-tree builds if you're not
familiar).

> rpmlint output at http://theory.physics.helsinki.fi/~jzlehtol/rpms/gromacs.lint
> 
> The zero-length makefile is the only "real" problem; maybe we need to find a
> workaround. The makefile for compiling user-made analysis software is generated
> on the fly by the build process. The other warnings are about missing
> documentation (which is in gromacs-share) and about devel-files in non-devel
> packages, which are runtime libraries needed anyway in the programs.

You are supposed to paste the rpmlint output in bugzilla, not just link to it.

Why are the .so files needed in the main package?

This can be easily fixed (run chmod in %prep on that file):
romacs-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/gromacs-4.0_rc2/src/tools/gmx_xpm2ps.c

Please post the current specfile (with the fixes you mentioned already applied
and with release increased by one). Also, please mention these fixes in the
changelog of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.