[Bug 225900] Merge Review: initscripts

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225900





--- Comment #4 from Bill Nottingham <notting at redhat.com>  2008-09-30 14:42:06 EDT ---
(In reply to comment #2)
> rpmlint on RPMS:
> 
> initscripts.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/netfs

init.d/* removed from %config.

> initscripts.i386: E: executable-marked-as-config-file
> /etc/sysconfig/network-scripts/ifup-ipsec

sysconfig/network-scripts/* removed from %config.

> initscripts.i386: E: executable-marked-as-config-file
> /etc/sysconfig/readonly-root

Permissions on /etc/sysconfig/* fixed. Oops.

> initscripts.i386: E: script-without-shebang /etc/sysconfig/readonly-root

See above.

> initscripts.i386: E: script-without-shebang /etc/rc.d/init.d/functions

Permissions fixed.

> initscripts.i386: W: non-conffile-in-etc /etc/udev/rules.d/88-clock.rules
> A non-executable file in your package is being installed in /etc, but is not a
> configuration file. All non-executable files in /etc should be configuration
> files. Mark the file as %config in the spec file.
> 
> Fine.

These are moved to /lib currently in any case.

> initscripts.i386: E: non-executable-script
> /etc/sysconfig/network-scripts/network-functions-ipv6 0644

Header of file fixed.

> initscripts.i386: E: non-standard-dir-perm /var/run/netreport 0775
> A standard directory should have permission set to 0755. If you get this
> message, it means that you have wrong directory permissions in some dirs
> included in your package.

That's actually correct the way it is.

> initscripts.i386: W: file-not-utf8 /usr/share/doc/initscripts-8.82/ChangeLog
> The character encoding of this file is not UTF-8.  Consider converting it in
> the specfile for example using iconv(1).
> 
> Fix.

This is generated from git history. I'm welcome to ideas as to how to do this.

> initscripts.i386: W: log-files-without-logrotate /var/log/btmp
> This package contains files in /var/log/ without adding logrotate
> configuration for them.

This isn't rotatable.

> initscripts.i386: W: obsolete-not-provided event-compat-sysv

See above re: obsoletes. Can't really replace hotplug as we don't
support those scripts any more.

> initscripts.i386: W: conffile-without-noreplace-flag /etc/X11/prefdm
> A configuration file is stored in your package without the noreplace flag. A
> way to resolve this is to put the following in your SPEC file:
> %config(noreplace) /etc/your_config_file_here

We need to force in changes here.

> initscripts.i386: W: conffile-without-noreplace-flag /etc/initlog.conf

Fixed.

> initscripts.i386: W: conffile-without-noreplace-flag /etc/profile.d/lang.csh

profile.d needs changes forced in. Possibly they should not be %config.

> initscripts.i386: W: dangerous-command-in-%post chown
> 
> Fix if you can.

It's needed.

> initscripts.i386: E: missing-mandatory-lsb-keyword Description in
> /etc/rc.d/init.d/netfs

Done.

> initscripts.i386: E: incoherent-subsys /etc/rc.d/init.d/netfs network
> The filename of your lock file in /var/lock/subsys/ is incoherent with your
> actual init script name. For example, if your script name is httpd, you have
> to use 'httpd' as the filename in your subsys directory. It is also possible
> that rpmlint gets this wrong, especially if the init script contains
> nontrivial shell variables and/or assignments.  These cases usually manifest
> themselves when rpmlint reports that the subsys name starts a with '$'; in
> these cases a warning instead of an error is reported and you should check the
> script manually.
> 
> initscripts.i386: E: incoherent-subsys /etc/rc.d/init.d/netfs rpcbind
> The filename of your lock file in /var/lock/subsys/ is incoherent with your
> actual init script name. For example, if your script name is httpd, you have
> to use 'httpd' as the filename in your subsys directory. It is also possible
> that rpmlint gets this wrong, especially if the init script contains
> nontrivial shell variables and/or assignments.  These cases usually manifest
> themselves when rpmlint reports that the subsys name starts a with '$'; in
> these cases a warning instead of an error is reported and you should check the
> script manually.
> 
> I'd love to have this fixed, but there may be valid reasons not to, at which
> point those should be documented in the spec.

This is rpmlint being very confused. The script does reference other lock
files, but it doesn't use them in the way it's complaining about.

> initscripts.i386: E: missing-mandatory-lsb-keyword Description in
> /etc/rc.d/init.d/network

Fixed.

Feel free to check out git for all the changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.