[Bug 225900] Merge Review: initscripts

bugzilla at redhat.com bugzilla at redhat.com
Tue Sep 30 19:55:20 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225900





--- Comment #9 from Jon Ciesla <limb at jcomserv.net>  2008-09-30 15:55:19 EDT ---
Missed one. . .

initscripts.src:255: W: macro-in-%changelog config
Macros are expanded in %changelog too, which can in unfortunate cases lead to
the package not building at all, or other subtle unexpected conditions that
affect the build.  Even when that doesn't happen, the expansion results in
possibly "rewriting history" on subsequent package revisions and generally odd
entries eg. in source rpms, which is rarely wanted.  Avoid use of macros in
%changelog altogether, or use two '%'s to escape them, like '%%foo'.

>> initscripts.i386: W: file-not-utf8 /usr/share/doc/initscripts-8.82/ChangeLog
>> The character encoding of this file is not UTF-8.  Consider converting it in
>> the specfile for example using iconv(1).
>> 
>> Fix.

> This is generated from git history. I'm welcome to ideas as to how to do this.

Is there no way iconv it in the spec?

> initscripts.i386: W: conffile-without-noreplace-flag /etc/profile.d/lang.csh

profile.d needs changes forced in. Possibly they should not be %config.

Agreed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.




More information about the Fedora-package-review mailing list