[Bug 458952] Review Request: SEMS - an extensible SIP media server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458952





--- Comment #18 from Jan ONDREJ <ondrejj at salstar.sk>  2009-04-08 02:17:39 EDT ---
My review is still not complete, but rpmlint shows these errors/warnings.
At least problems with my comments should be fixed.

sems-conf_auth.i386: W: only-non-binary-in-usr-lib
sems-conf_auth.i386: E: zero-length /etc/sems/etc/conf_auth.conf

- try to add at least some comments to this file. An link to documentation can
be useful for users.

sems-gateway.i386: W: no-documentation
sems-gsm.i386: W: no-documentation
sems-ivr.i386: E: script-without-shebang /usr/lib/sems/plug-in/log.py

- please, consider, if this file should be executed directly or only included
from other python script. For first situation add shebang, for second remove
execute flag from this script.

sems-mailbox.i386: W: only-non-binary-in-usr-lib
sems-pin_collect.i386: W: only-non-binary-in-usr-lib
sems-python.i386: E: script-without-shebang
/usr/lib/sems/plug-in/py_sems_log.py

- same problem as above.

sems-speex.i386: W: no-documentation
sems.src: W: mixed-use-of-spaces-and-tabs (spaces: line 173, tab: line 1)

- fix this

sems.src: W: patch-not-applied Patch0: sems--openser_enable.diff

- I think you can remove this patch, but if you need it for possible further
usage, it's only a warning.
Which version of openser is needed to use sems without this patch? Current
fedora package is enough?

12 packages and 0 specfiles checked; 3 errors, 8 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.