[Bug 490849] Review Request: php-ezc-Archive- eZ Components Archive

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490849


Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at famillecollet.com
         AssignedTo|nobody at fedoraproject.org    |fedora at famillecollet.com
               Flag|                            |fedora-review+




--- Comment #3 from Remi Collet <fedora at famillecollet.com>  2009-04-27 03:48:06 EDT ---
REVIEW:

+ rpmlint is ok
php-ezc-Archive.src: I: checking
php-ezc-Archive.noarch: I: checking
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
+ package name ok
+ spec file name ok
+ package meet the PHP Guidelines (new update)
+ License ok : BSD
+ License is upstream 
+ spec in english and legible
+ license file in sources is provided
+ sources match the upstream sources
0400c9d03f8a3bba4ec3093428e7ef2a  Archive-1.3.3.tgz
+ Source URL ok
+ build  on F10.x86_64
+ BuildRequires (php-pear >= 1:1.4.9-1.2, php-channel(components.ez.no)) ok
+ no locale
+ no .so
+ own all directories that it creates
+ no duplicate file
+ %defattr ok
+ %clean section
+ use macros consistently
+ contain code
+ small documentation not required to run
+ no devel
+ no pkgconfig
+ no sub-package
+ no GUI
+ don't own files or directories already owned by other packages
+ %install start with rm -rf 
+ valid UTF-8
+ build in mock (fedora-rawhide-x86_64)
+ no test suite
+ scriptlets ok
+ Final Requires ok
php-common >= 5.2.1
php-pear(components.ez.no/Base) >= 1.6.1
php-posix  
+ Final Provides ok
php-pear(components.ez.no/Archive) = 1.3.3
php-ezc-Archive = 1.3.3-1.fc8

Good catch for php-posix (split from php-common in F11)

--------
APPROVED
--------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.