[Bug 492831] Review Request: libmkv - An alternative to the official libmatroska library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492831


Xavier Bachelot <xavier at bachelot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |xavier at bachelot.org
         AssignedTo|nobody at fedoraproject.org    |xavier at bachelot.org
               Flag|                            |fedora-review+




--- Comment #1 from Xavier Bachelot <xavier at bachelot.org>  2009-04-01 18:08:12 EDT ---
+ MUST: rpmlint output is ok. The only warning can be ignored :
libmkv-devel.i386: W: no-documentation
+ MUST: package name follows guidelines.
+ MUST: Spec file name is ok.
+ MUST: The package must meet the Packaging Guidelines.
+ MUST: License is ok for Fedora.
+ MUST: License field mactch actual license.
+ MUST: License file is included in %doc
+ MUST: Spec file in legible American English.
+ MUST: Source file match upstream. MD5 : 984575069cbfb47dece609e78768ca97
+ MUST: builds fine on F10 i386 in mock.
+ MUST: BuildRequires are ok. 
+ MUST: ldconfig is used in %post and %postun.
+ MUST: owns all dirs it creates.
+ MUST: No file listed more than once in %files.
+ MUST: Permissions on files are appropriate. %defattr is properly used.
+ MUST: %clean section contains rm -rf $RPM_BUILD_ROOT).
+ MUST: Macros are used consistently.
+ MUST: code, not content.
+ MUST: %doc not needed at runtime.
+ MUST: Header files are in a -devel package.
+ MUST: .so libfile in -devel.
+ MUST: -devel package requires base package.
+ MUST: .la libtool archives are not included.
+ MUST: doesn't own files or directories already owned by other packages.
+ MUST: %install begins with rm -rf $RPM_BUILD_ROOT.
+ MUST: All filenames are valid UTF-8.

Notes :
- Theses backslashes are un-needed : %{_libdir}/libmkv\.so\.*. This should be
fixed.
- You can prevent libmkv.a to be built by adding --disable-static to
%configure.
- URL: and Source0: urls are strange, but I don't think you can do any better
unfortunately.

Please fix the backslashes, then this package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.