[Bug 493521] Review Request: perl-Log-Trace - A unified approach to tracing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493521





--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-04-02 01:16:24 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1272037
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
773aefa7539b1857edb3e225cfbc4a22  Log-Trace-1.070.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=13, Tests=80,  0 wallclock secs ( 0.05 usr  0.03 sys +  0.38 cusr  0.08
csys =  0.54 CPU)
+ Package perl-Log-Trace-1.070-1.fc11.noarch =>
  Provides: perl(Log::Trace) = 1.070
  Requires: perl(Carp) perl(Fcntl) perl(strict) perl(vars)

Can you please help me understand why to use AutoProv and why not to filter and
remove unnecessary provides perl(DB)?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.