[Bug 454010] Review Request: iaxclient - Library for creating telephony solutions that interoperate with Asterisk

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454010


Deji Akingunola <dakingun at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




--- Comment #11 from Deji Akingunola <dakingun at gmail.com>  2009-04-02 23:45:15 EDT ---
I am sorry for the delay, I failed to notice you posted the correct link
(drowned in a load of other mails at the time).

REVIEW:
- GOOD: package name according to guidelines
- GOOD: spec file named properly
- GOOD: license acceptable (LGPLv2+) and COPYING.LIB file shipped as
documentation
- CHECK: Most of the source codes doesn't include and license header at all
- GOOD: the spec file is written in good English
- GOOD: the spec file is legible
- GOOD: download URL works
- GOOD: source tarball is the same as from
   md5sum: 47d54b9d5d48dc6aa1f6d7e506c72ba7  iaxclient-2.1beta3.tar.gz
- GOOD: builds in mock for x86_64/Rawhide
- GOOD: all build dependencies (currently available in Fedora) listed
- PASS: no locale files
- GOOD: post and postun scriplets properly called for the libraries shipped
- GOOD: all shipped files and directories owned by package
- GOOD: permissions on files are set properly
- GOOD: package has a %clean section
- GOOD: package uses macros consistently
- GOOD: the package contains code, not content
- PASS: no large documentation files
- GOOD: %doc doesn't affect runtime
- GOOD: header files properly shipped in -devel subpackage
- PASS: no static libraries
- GOOD: pkgconfig file properly shipped in -devel subpackage
- GOOD: no *.la libtool archives
- GOOD: desktop file is installed properly in %install
- GOOD: doesn't own files or directories owned by other packages
- GOOD: build root is cleaned at the beginning of %install
- PASS: Seems to consistently follow some tcl specific guidelines, which I
cannot locate on the wiki

- CHECK: rpmlint warning on the iaxclient binary as in comment #5 is still
there. Since its a warning and I'm not sure what it means, I'll let it pass.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.