[Bug 470703] Review Request: links 2 - text mode browser with graphics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470703


Ondrej Vasik <ovasik at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |ovasik at redhat.com




--- Comment #23 from Ondrej Vasik <ovasik at redhat.com>  2009-04-03 05:12:28 EDT ---
Ok, just quick check first...

1) 
#Issue:
#  There is a symlink in /usr/bin/links to elinks if that package is installed
#  Should this package use links2 or should I modify elinks to remove the links
#  symlink from elinks
- this comment in spec should be removed as elinks/links2 now uses
alternatives.

2)
Many warnings "pointer targets in passing argument <N> of <variable> differ in
signedness" in build.log still ... upstream should address those...  maybe just
adding Mikulas to that review could be ok.

The rest of the spec file looks sane to me (except one trailing space in build
section - line with mv converted.AUTHORS ). 

Question: Shouldn't be that NSS support enabled via configure option (like in
elinks?). This should be easier to get into upstream ...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.