[Bug 468597] Review Request: rubygem-ferret - Full-featured text search engine library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468597


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #38 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-04-05 14:29:48 EDT ---
Notes:

- BR: findutils is redundant. See:
  https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

- Would you check if "setup.rb" "Rakefile" are really needed?
  If it is needed, I think "setup.rb" should be moved to %doc

- %defattr(755, root, root, -) is redundant because the permission
  of ferret_ext.so is explicitly changed to 0755
  ! Note: It is needed anyway to make it sure that ferret_ext.so
    has 0755 permission before %install ends because otherwise
    find-debuginfo.sh won't work correctly.

- %exclude %{geminstdir}/Rakefile is redundant (no glob is used
  here)

! Not a blocker, however as ruby maintainer would you examine
  why "rake test_units" fails on ppc64?
  By the way it is preferable to enable tests as much as possible
  like
---------------------------------------------------------------
%check
pushd .%{geminstdir}
%ifarch %{ix86} x86_64 ppc
rake test_units
%else
rake test_units || :
%endif
---------------------------------------------------------------

But other things are okay.

---------------------------------------------------------------
     This package (rubygem-ferret) is APPROVED by mtasaka
---------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.