[Bug 484049] Review Request: emacs-common-proofgeneral - Emacs mode for standard interaction interface for proof assistants

bugzilla at redhat.com bugzilla at redhat.com
Mon Apr 6 18:55:49 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484049


Jerry James <loganjerry at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |loganjerry at gmail.com
         AssignedTo|nobody at fedoraproject.org    |loganjerry at gmail.com




--- Comment #1 from Jerry James <loganjerry at gmail.com>  2009-04-06 14:55:48 EDT ---
There was a small error in the XEmacs template (since fixed); there is supposed
to be a "lisp" directory after %{_datadir}/xemacs/site-packages.  That is,
please fix the following definitions at the top of the spec file:

%if %($(pkg-config xemacs) ; echo $?)
%define xemacs_version 21.5
%define xemacs_lispdir %{_datadir}/xemacs/site-packages/lisp
%define xemacs_startdir %{_datadir}/xemacs/site-packages/lisp/site-start.d

This doesn't cause any problems because pkg-config gives the right values, but
it doesn't hurt to be safe...

The file %{emacs_lispdir}/proofgeneral/images/README is installed as a regular
file in the emacs-proofgeneral package.  Shouldn't that be a documentation
file?

The entire mmm and x-symbol distributions are included in the
emacs-proofgeneral and xemacs-proofgeneral packages.  (And the x-symbol .el
files are NOT included in (x)emacs-proofgeneral-el!)  I think this is wrong. 
The mmm and x-symbol packages should be submitted separately, with the
proofgeneral package depending on them.

Furthermore, mmm and x-symbol are already available for XEmacs in
xemacs-packages-extra, so they only need to be made available for Emacs.  If
the provides/requires have been setup properly, all you should need to do is
NOT install them for XEmacs and add "Requires: xemacs-package-extra" to the
xemacs-proofgeneral package.

I will do a full review shortly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list