[Bug 492609] Review Request: hmaccalc - Tools for computing and checking HMAC values for files

bugzilla at redhat.com bugzilla at redhat.com
Mon Apr 6 22:00:43 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492609





--- Comment #4 from Nalin Dahyabhai <nalin at redhat.com>  2009-04-06 18:00:43 EDT ---
(In reply to comment #3)
> I understand why you need to generate the checksums after rpm is done poling at
> the binaries; I was just confused by the language in use:
> 
>   This overrides the default which was in place at least from Red Hat Linux 9 
>   through Fedora 11's development cycle.
> 
> which (to me, at least) sort of sounds like it's overriding some sort of
> default checksum generation.  Not that's it's in any way material, but perhaps
> it will explain my confusion.

Oh, I see what you mean.  It's overriding the macro to wire in the generation
of the HMAC values after the default buildroot policies are run.  I don't have
better text ready, but I'd appreciate any suggestions.

> Anyway, I guess it's not reasonable to run the test suite unless you somehow
> compile a specal version that doesn't check its checksums.  I guess it would be
> nice if the executables had some way to skip the verification, but absent that
> the test suite isn't useful.

Yeah, still trying to come up with a good fix for that.

> Finally, the issue of where to put the checksums.  Given the problems with the
> alternatives, %{_libdir} seems fine, rpmlint's complaint about it
> nonwithstanding.
> 
> I guess that covers everything.  APPROVED  

Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list