[Bug 494647] Review Request: emacs-mmm - Emacs minor mode allowing different major modes in the same file

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=494647


Jerry James <loganjerry at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |loganjerry at gmail.com
         AssignedTo|nobody at fedoraproject.org    |loganjerry at gmail.com




--- Comment #1 from Jerry James <loganjerry at gmail.com>  2009-04-08 13:09:57 EDT ---
I have a couple of questions about the spec file:

1) Is there some reason to avoid the %configure macro in the spec file?  (And
"s/Not/Note" in the comment above the configure invocation if so.)

2) Shouldn't this package "Requires: emacs(bin)"?

You noted a problem with "make mmm.pdf".  The problem is that the texinfo.tex
in the mmm-mode distribution is being used, and it is too old (it's from
1999!).  Just rm it, and then the system texinfo.tex gets used, and you get a
good build.

Some of the Emacs Lisp warnings have me concerned, especially the notes that
regexp-opt is being called with 3 arguments but only accepts 1 or 2.  This is
almost certain to lead to broken compiled code.  I'll make a patch for you. 
Hang on....

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.