[Bug 485961] Review Request: gmusicbrowser - Jukebox for large collections of music files

bugzilla at redhat.com bugzilla at redhat.com
Sun Apr 12 05:38:31 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485961





--- Comment #3 from Remi Collet <fedora at famillecollet.com>  2009-04-12 01:38:30 EDT ---
@quentin : can you fix the upstream Makefile to preserve timestamp (probably
defining an INSTALL macro as -p option is perhaps not supported everywhere)

@simon : I agree we should preserve timestamp as much as possible, but I don't
think this is a must when upstream don't care (Guidelines says "When adding
file copying commands in the spec file...") : anyway, fixed

I've changed to "make install DESTDIR=%{buildroot}" as it is supported by the
Makefile.

Spec URL: http://remi.fedorapeople.org/gmusicbrowser.spec
SRPM URL: http://remi.fedorapeople.org/gmusicbrowser-1.0.1-2.fc8.src.rpm

%changelog
* Sun Apr 12 2009 Remi Collet <Fedora at FamilleCollet.com> - 1.0.1-2
- From review (#485961)
- preserve timestamp
- own all directory
- missing Requires
- fix license

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list