[Bug 495357] Review Request: python-twill - Simple scripting language for Web browsing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495357


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name




--- Comment #1 from Till Maas <opensource at till.name>  2009-04-12 07:50:55 EDT ---
Just some quick observations:

The pyver macro seems not to be used, therefore it should be probably skipped:

%{!?pyver: %define pyver %(%{__python} -c "import sys ; print
sys.version[:3]")}

Also this should use at least %global instead of %define:

%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}

Reference:
https://fedoraproject.org/wiki/Packaging:Python#System_Architecture

Also the patch is not commented.

Reference:
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.