[Bug 495403] Review Request: perl-MooseX-Storage - An serialization framework for Moose classes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495403


Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |iarnell at gmail.com
         AssignedTo|nobody at fedoraproject.org    |iarnell at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Iain Arnell <iarnell at gmail.com>  2009-04-13 02:22:36 EDT ---
+ source files match upstream.  
  89f835ca0cad9a2c3707cb8f748bc44f43dc6112  MooseX-Storage-0.17.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
- summary matches upstream, but is poor English. Should be
  "A serialization framework for Moose classes" (not "An...")

+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
  GPL+ or Artistic

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1292522

+ package installs properly.
+ rpmlint has no complaints:
  perl-MooseX-Storage.noarch: I: checking
  perl-MooseX-Storage.src: I: checking
  2 packages and 0 specfiles checked; 0 errors, 0 warnings.

- final provides and requires:
  perl(Moose::Meta::Attribute::Custom::DoNotSerialize) = 0.17
  perl(Moose::Meta::Attribute::Custom::Trait::DoNotSerialize) = 0.17
  perl(MooseX::Storage) = 0.17
  perl(MooseX::Storage::Base::WithChecksum) = 0.17
  perl(MooseX::Storage::Basic) = 0.17
  perl(MooseX::Storage::Deferred) = 0.17
  perl(MooseX::Storage::Engine) = 0.17
  perl(MooseX::Storage::Engine::IO::AtomicFile) = 0.17
  perl(MooseX::Storage::Engine::IO::File) = 0.17
  perl(MooseX::Storage::Format::JSON) = 0.17
  perl(MooseX::Storage::Format::Storable) = 0.17
  perl(MooseX::Storage::Format::YAML) = 0.17
  perl(MooseX::Storage::IO::AtomicFile) = 0.17
  perl(MooseX::Storage::IO::File) = 0.17
  perl(MooseX::Storage::IO::StorableFile) = 0.17
  perl(MooseX::Storage::Meta::Attribute::DoNotSerialize) = 0.17
  perl(MooseX::Storage::Meta::Attribute::Trait::DoNotSerialize) = 0.17
  perl(MooseX::Storage::Util) = 0.17
  perl-MooseX-Storage = 0.17-1.fc11

=
  perl(:MODULE_COMPAT_5.10.0)  
  perl(Best)  
  perl(Data::Dumper)  
  perl(Digest)  
  perl(IO::AtomicFile)  
  perl(IO::File)  
  perl(JSON::Any)  
  perl(Moose)  
  perl(Moose::Role)  
  perl(MooseX::Storage::Engine)  
  perl(MooseX::Storage::Engine::IO::AtomicFile)  
  perl(MooseX::Storage::Engine::IO::File)  
  perl(MooseX::Storage::Meta::Attribute::DoNotSerialize)  
  perl(Scalar::Util)  
  perl(Storable)  
  perl(utf8)  
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(FileDigests) <= 4.6.0-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rpmlib(VersionedDependencies) <= 3.0.3-1

+ %check is present and all tests pass.
  All tests successful.
  Files=27, Tests=349, 14 wallclock secs ( 0.20 usr  0.06 sys + 13.43 cusr 
0.76 csys = 14.45 CPU)
  Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


Minor niggle with the summary.  And you need to filter the provides:
  perl(Moose::Meta::Attribute::Custom::DoNotSerialize) = 0.17
  perl(Moose::Meta::Attribute::Custom::Trait::DoNotSerialize) = 0.17

Other than that, APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.