[Bug 495372] Review Request: python-altgraph - Python graph (network) package

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495372


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-04-13 11:36:57 EDT ---
rpmlint output is clean.

MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK

MUST: The spec file for the package is legible and macros are used
consistently. OK
- You could omit the ./ in front of setup.py since it's already run explicitly
by python.

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
~OK
- No license headers are present in source code (except __init__.py) and no
license file is included. According to PKG-INFO and __init__.py license is MIT.
- Please ask upstream to add license headers.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL.  OK
MUST: Optflags are used and time stamps preserved. OK
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK

MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. NEEDSFIX
- Add PKG-INFO to %doc. Also, I'd just include test_altgraph.py and omit the
test/ directory.

MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

You can do the fixes upon import to CVS. The package has been

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.