[Bug 495021] Review Request: python-posix_ipc - POSIX IPC primitives for Python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495021


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-04-15 01:47:53 EDT ---
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1299556
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
ab3699b185e7e10918b21753e8b9c20b  posix_ipc-0.5.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.
+ Package python-posix_ipc-0.5.3-1.fc11.i586 =>
Provides: posix_ipc.so
Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3.4)
libc.so.6(GLIBC_2.4) libpthread.so.0 libpthread.so.0(GLIBC_2.0)
libpthread.so.0(GLIBC_2.1) libpthread.so.0(GLIBC_2.1.1)
libpthread.so.0(GLIBC_2.2) libpython2.6.so.1.0 librt.so.1 librt.so.1(GLIBC_2.2)
librt.so.1(GLIBC_2.3.4) librt.so.1(GLIBC_2.7) python(abi) = 2.6 rtld(GNU_HASH)


Suggestions:
1) remove unnecessary comments
2) remove sitelib macro line in top of SPEC.
3) good to add directories demo and demo2 to %doc
4) License should be GPLv3+

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.