[Bug 487114] Review Request: gvrpcd - A program for announcing VLANs using GVRP.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487114





--- Comment #10 from Michael Schwendt <bugs.michael at gmx.net>  2009-04-18 05:44:08 EDT ---
* Source tarball URL gives 404 Not Found. It's missing the "gvrpcd" directory.
Correct would be:

Source0: http://sokrates.mimuw.edu.pl/~sebek/%{name}/%{name}-%{version}.tar.gz


* A proper exit(..) call at end of main() would eliminate the following
compiler warning:
gvrpcd.c:290: warning: control reaches end of non-void function


* "Short-Description" in initscript contains a typo: s/annoucing/announcing/


* You've still got the start-by-default problem (see bottom of comment 2) where
the daemon is started even if VLAN configuration is missing:

$ sudo service gvrpcd start
Starting gvrpcd-eth0:                                      [  OK  ]
$ sudo service gvrpcd status
gvrpcd-eth0 dead but pid file exists

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.