[Bug 453422] Review Request: songbird - Mozilla based multimedia player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453422





--- Comment #61 from David Halik <auralvance at gmail.com>  2009-04-18 12:04:13 EDT ---
Ok, I reworked the files section and all of the rpmlint perm errors are fixed,
this includes the debuginfo package. Below is the new rpmlint output:

# rpmlint songbird-1.1.2-2.fc11.x86_64.rpm
songbird.x86_64: W: hidden-file-or-dir /usr/lib64/songbird-1.1.2/.autoreg
songbird.x86_64: E: zero-length /usr/lib64/songbird-1.1.2/.autoreg
songbird.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/songbird-1.1.2/xulrunner/mangle ['/usr/lib64/songbird-1.1.2',
'$ORIGIN/../lib64', '$ORIGIN/../lib']
songbird.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/songbird-1.1.2/xulrunner/shlibsign ['/usr/lib64/songbird-1.1.2',
'$ORIGIN/../lib64', '$ORIGIN/../lib']
songbird.x86_64: W: no-soname
/usr/lib64/songbird-1.1.2/lib/sbGStreamerMediacore.so
songbird.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/songbird-1.1.2/components/sbMetadataHandlerTaglib.so
['/usr/lib64/songbird-1.1.2', '$ORIGIN/../xulrunner']
1 packages and 0 specfiles checked; 4 errors, 2 warnings.

Everything above is accounted for. The .autoreg warning and error are expected.
The zero byte file needs to be there for XPCOM registration to happen on first
run (I checked with the devs).

kwizart, I'm not sure which other RPATH errors you were seeing, but the above
three (mangle, shlibsign, sbMetadataHandlerTaglib.so) are the only ones I have
seen and all are correct. These three should be pointing back to the internal
lib area rather than outside.

# rpmlint songbird-debuginfo-1.1.2-2.fc11.x86_64.rpm
/usr/share/rpmlint/Pkg.py:16: DeprecationWarning: The popen2 module is
deprecated.  Use the subprocess module.
  import popen2
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

debuginfo perms are now correct.

I posted the update spec and src.rpm:

http://rpm.rutgers.edu/fedora/songbird.spec
http://rpm.rutgers.edu/fedora/songbird-1.1.2-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.