[Bug 496166] Review Request: sakura - Terminal emulator based on GTK and VTE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=496166





--- Comment #4 from Christoph Wickert <fedora at christoph-wickert.de>  2009-04-18 21:00:55 EDT ---
(In reply to comment #2)
> You and your terminal emulators :)  

Gift for Robert Scheck who complained there are no good light terminals in
Fedora. ;)

(In reply to comment #3)
> Optflags are not honored:

Good catch. This is because of
  IF (${CMAKE_BUILD_TYPE} MATCHES "Debug")
 SET (CMAKE_C_FLAGS "-Wall")
  ELSE (${CMAKE_BUILD_TYPE} NOT MATCHES "Debug")
 SET (CMAKE_C_FLAGS "-O2")
  ENDIF (${CMAKE_BUILD_TYPE} MATCHES "Debug")

So it can't be overwritten with
  %cmake DCMAKE_C_FLAGS=%{optflags} .

Two solutions that I can think of:
Patch CMakeLists.txt and remove the 'else ...' statement or
  sed -i 's!CMAKE_C_FLAGS "-O2"!CMAKE_C_FLAGS "%{optflags}"!' CMakeLists.txt

What do you think is better?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.