[Bug 496424] Review Request: perl-Test-Aggregate - Aggregate C<*.t> tests to make them run faster
bugzilla at redhat.com
bugzilla at redhat.com
Sun Apr 19 08:47:10 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496424
Iain Arnell <iarnell at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |iarnell at gmail.com
AssignedTo|nobody at fedoraproject.org |iarnell at gmail.com
Flag| |fedora-review+
--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2009-04-19 04:47:09 EDT ---
+ source files match upstream.
495a0c853951d326df5322e97bcbc9c53a71eea9 Test-Aggregate-0.35.tar.gz
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
GPL+ or Artistic
+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
http://koji.fedoraproject.org/koji/taskinfo?taskID=1307346
+ package installs properly.
+ rpmlint has no complaints:
perl-Test-Aggregate.noarch: I: checking
perl-Test-Aggregate.src: I: checking
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
+ final provides and requires are sane:
perl(Test::Aggregate) = 0.35
perl(Test::Aggregate::Builder) = 0.35
perl-Test-Aggregate = 0.35-1.fc11
=
perl(:MODULE_COMPAT_5.10.0)
perl(Carp)
perl(File::Find)
perl(Test::Aggregate)
perl(Test::Aggregate::Builder)
perl(Test::Builder)
perl(Test::Builder::Module)
perl(Test::More)
perl(strict)
perl(vars)
perl(warnings)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
+ %check is present and all tests pass.
All tests successful.
Files=5, Tests=48, 4 wallclock secs ( 0.07 usr 0.02 sys + 0.58 cusr 0.07
csys = 0.74 CPU)
Result: PASS
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list