[Bug 496478] Review Request: perl-WWW-Pastebin-RafbNet-Create - Create new pastes on http://rafb.net/

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=496478





--- Comment #1 from Chris Weyl <cweyl at alumni.drew.edu>  2009-04-19 16:14:44 EDT ---
There's an examples/ directory; why not include it under %doc?

There's a missing dep on Class::Data::Accessor, due to a 'use base' construct.
Please add this before building...

Otherwise, looks good.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1307894

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
af8ee45f6bbf1efede1c725ae6556a529199f29d
WWW-Pastebin-RafbNet-Create-0.001.tar.gz
af8ee45f6bbf1efede1c725ae6556a529199f29d
WWW-Pastebin-RafbNet-Create-0.001.tar.gz.srpm

Final provides / requires are sane (with the above caveat):

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-WWW-Pastebin-RafbNet-Create-0.001-1.fc10.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-WWW-Pastebin-RafbNet-Create-0.001-1.fc10.src.rpm
====> requires for perl-WWW-Pastebin-RafbNet-Create-0.001-1.fc10.src.rpm
perl(Class::Data::Accessor) >= 0.04001
perl(LWP::UserAgent) >= 2.036
perl(Module::Build)  
perl(Test::Kwalitee)  
perl(Test::More)  
perl(Test::Pod)  
perl(Test::Pod::Coverage)  
perl(URI) >= 1.35

=====> perl-WWW-Pastebin-RafbNet-Create-0.001-1.fc10.noarch.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-WWW-Pastebin-RafbNet-Create-0.001-1.fc10.noarch.rpm
perl(WWW::Pastebin::RafbNet::Create) = 0.001
perl-WWW-Pastebin-RafbNet-Create = 0.001-1.fc10
====> requires for perl-WWW-Pastebin-RafbNet-Create-0.001-1.fc10.noarch.rpm
perl(base)  
perl(Carp)  
perl(LWP::UserAgent)  
perl(:MODULE_COMPAT_5.10.0)  
perl(overload)  
perl(strict)  
perl(URI)  
perl(warnings)  

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.