[Bug 488174] Review Request: nimbus-theme-gnome - The Nimbus theme originally from Sun

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488174


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |fedora at christoph-wickert.de
               Flag|                            |fedora-review?




--- Comment #7 from Christoph Wickert <fedora at christoph-wickert.de>  2009-04-20 23:11:58 EDT ---
(In reply to comment #5)
> - gtk-nimbus-engine (arch, includes libnimbus.so and gtkrc, requires
> gtk-engines for dir ownership)

Sorry, it's gtk2-engines. And the reqirement for hicolor-icon-theme (not
hicolor-icon) can be dropped since %{_datadir}/icons is provided by the
filesystem package. My bad.


(In reply to comment #6)
> Unfortuantely noarch package cannot have arch subpackage, so nimbus-theme-gnome
> must be arch as well.

You can easily work around that by renaming spec and srpm to nimbus-theme,
nimbus-gnome-theme or whatever, as long as it's not nimbus-theme-gnome. The
'pseudo' base package will have no requirements and no files and the gnome bits
will be a new subpackage.

gtk-nimbus-engine, nimbus-icon-theme and nimbus-metacity-theme must not require
nimbus-theme-gnome but contrary nimbus-theme-gnome requires them.

Again you have duplicate files in the files section, because you made the icon
theme own %{_datadir}/themes/nimbus/ which also includes index.theme and
gtk-2.0/{gtkrc,iconrc}. Correct would be
  %dir %{_datadir}/themes/nimbus/
  %dir %{_datadir}/themes/nimbus/gtk-2.0/
  %{_datadir}/themes/nimbus/gtk-2.0/iconrc
  %{_datadir}/themes/nimbus/gtk-2.0/*.png

But IMO this is wrong anyway, because all these icons and iconrc should be
installed to %{_datadir}/icons/nimbus/24x24/stock. I will attach a patch to fix
that and then you don't need to care for duplicate ownership any longer.

gtk-nimbus-engine and nimbus-metacity-theme also need to own 
  %dir %{_datadir}/themes/nimbus/

The gtk engine would also need to own
  %dir %{_datadir}/themes/nimbus/gtk-2.0/
but with the patch just owning %{_datadir}/themes/nimbus/gtk-2.0/ will be ok,
since the icons were moved away.

Drop NEWS ("No News") and README (Sun internal info) from %doc. 

All packages should ship AUTHORS, ChangeLog and COPYING, this is no violation
of the duplicate files rule but we need to ship this info with every package
(except the gnome one maybe).

The icon theme needs to run the scriptlets from
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache
for the nimbus folder and include icon-theme.cache as %ghost.

Regarding index.theme: Is there a nimbus-notification theme?

The license is not clear. Is it LGPLv2 or LGPLv2+? Can you ask upstream for
clarification please?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.