[Bug 496757] Package Review: ibus-table-yong
bugzilla at redhat.com
bugzilla at redhat.com
Wed Apr 22 04:00:54 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=496757
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Flag| |fedora-review?
--- Comment #2 from Parag AN(पराग) <panemade at gmail.com> 2009-04-22 00:00:53 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1313840
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
3d8a91a171e16c6eac4c9c2f2b3ac218 ibus-table-yong-1.1.0.20090422.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
Suggestions:
1) I think its ok to drop following line from %description
Erbi is released under released under GPLv3.
or modify to replace Erbi to Yong
2) can you remove following
%verify(not md5 size mtime) ?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list