[Bug 490588] Review Request: minicomputer - Software Synthesizer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490588





--- Comment #8 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com>  2009-04-22 11:28:21 EDT ---
(In reply to comment #7)
> No, no, I now speak about using all flags hard defined in SConstruct. You are
> put standard Fedora %optflags into begin of its (via sed in spec file), but
> followed flags its override!!!
> 

I am not familiar with all of those flags, but as far as I know, none of 
   '-fwhole-program',
   '-ftree-vectorize',
   '-ffast-math', 
   '-funit-at-a-time',
   '-fpeel-loops',
   '-ftracer',
   '-funswitch-loops',
   '-fprefetch-loop-arrays'
is overriding the Fedora flags. The author picked these probably because these
are application specific.

> I think it is bad idea at all. If you expect from SSE big advantage, you may
> add it to standard set, defined widely for current platform, but comment in
> spec for that needed why you do that.  

Again, afaik the code should support SSE if you want to use those flags. 

I think that my comment is clear about this. It says that SSE is only enabled
in those supported archs for obvious reasons. What do you want me to add to it?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.