[Bug 486302] Review Request: parrot - Parrot Virtual Machine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486302





--- Comment #37 from Lubomir Rintel <lkundrak at v3.sk>  2009-04-23 15:06:49 EDT ---
Seems much better. Thanks a lot for your effort! I'll take a closer look on
weekend and approve this unless there's something serious, which is unlikely.
Until then, there's a couple of minor issues that may need some attention:

1.) Are you sure you want to pin this to one specific version?
Using >= 0.05 would make much more sense. Even if 0.06 or some later version
breaks this, it wouldn't make things any worse and save you from having to bump
this on updates.

Requires:       perl(File::Which) = 0.05

2.) Booo, this sucks :)

...
%else
# PowerPC, not all options work with the PowerPC-architecture, I do not test
# which is not working   (Gerd)

When compiled on non-x86, compiler complains about non-existent
-maccumulate-outgoing-args option. Why is it needed? Remove it, or make it
conditional for x86, rest of Configure.pl options seem to work well on powerpc.

3.) Why is this conditional?

%{?_with_fulltest: make fulltest}

Does it take a lot of time? If yes, it should still be used for production
builds and disabled for development ones; having the condition effectively
reverted, replacing _with_fulltest by _without_fulltest.

4.) Please exclude static library:

%{_libdir}/libparrot.a

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.