[Bug 497441] Review Request: mumble - Voice chat application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497441


Andreas Osowski <th0br0 at mkdir.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |th0br0 at mkdir.name




--- Comment #6 from Andreas Osowski <th0br0 at mkdir.name>  2009-04-24 10:36:17 EDT ---
Hello,
damn, you were two days faster than me :D 
I was intending to request a review for mumble, too... 
Anyway... 

You've got a very interesting approach there.
Might I ask why you create your own main.pro file?
I've -- so far -- installed everything manually.
Besides of that we don't want the speex version supplied with mumble, so
disable it. -- oh I just saw that you appear to be disabling it... 

Same goes for XEVIE (as that requires a modification of the xorg.conf) and
embedded qt translations I guess...

You should set the PLUGIN_PATH to something when running qmake (it's a DEFINE)
Otherwise it will locate to something default that we don't want.
Thus, liblink.so should be isntalled to somewhere else like /usr/lib/mumble/

Christoph has already said that you should make two packages out of mumble and
murmur, the server should not be installed automatically.

The description contains incorrect English
<snip>
Mumble is client application witch connects to
running Murmur server.

Murmur is server application to witch clients 
connect.
</snip>

Should be:
<snip>
Mumble is a client application for the Murmur
server.

Murmur is the server application to which Mumble
clients can connect.
</snip>
Mind that I'd -- personally -- not put those two phrases in there at all, it's
already said in the paragraph above.

According to the guidelines, packages ending with .so should only be included
in the -devel packages. 

The license is not GPLv2+ but BSD.

Source0 should not point to a specific SF server but rather to
http://downloads.sourceforge.net

Why are you only installing the icons with a 32x32 resolution and not all
available?

In %install you don't adhere to the smp_flags,
make install 
should be:
make install %{?_smp_mflags}

So much for now and for a quick glance.

If you are interested in seeing my spec file / SRPM:
Spec URL:
http://fedora.mkdir.name/packages/mumble-1.1.8/mumble.spec
SRPM URL:
http://fedora.mkdir.name/packages/mumble-1.1.8/mumble-1.1.8-1.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.