[Bug 497441] Review Request: mumble - Voice chat application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497441





--- Comment #12 from Igor Jurišković <juriskovic.igor at gmail.com>  2009-04-24 18:28:26 EDT ---
> ------------------------
> (In reply to comment #4)
> > Mumbles needs to be patched to use the speex from Fedora and not the included
> > one.
> "no-bundled-speex" is a CONFIGS parameter to do this 
> 
Done
> - remove your created make.pro
Removed

> 
> - Correct the Description as cwickert says.
> -- You can use texts from upstreams hp/wiki 
Fixed

> 
> - correct License
> the correct license is BSD 
> 
Done

> - correct url
> http://mumble.sourceforge.net/
> please don't use the "sf"-token 
> 
Done

> - correct SOURCE
> http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
> Please don't select a specific sourceforge-mirror.
> 
Done

> - add missing build requirements
> -- spexx-devel is needed for build without bundled spexx
> -- desktop-file-utils is needed for the desktop file install
> you need some more, please recheck this.
> 
Done

> - split package in mumble and murmur (with -n)
> %package -n murmur
> this package needs a summary and a description and a group, too.
> you can add a description on this way
> %description -n murmur 
> create an own filelist 
> %files -n murmur 
> for murmur
> 
Did but you'll have to take a look at it

> - add a new user "murmur" for murmur
> you need a user for the murmur process. it makes sense to name this user
> "murmur"
> 
Did but you take a look

> - add persmissions for "murmur" on murmur related files 
> you can handle this with %attr in %files
>
Done but take a look

> - Add to make install
> -- INSTALL="install -p" for perserve timestamps
> -- INSTALL_ROOT="%buildroot" will install in the buildroot 
>
Problematic part. If you remove main.pro(like you said) then there is NO make
install and you have to install everything by hand using "install". So there is
no point in doing INSTALL_ROOT="%{buildroot}". Or am I wrong?


> - Use CONFIG and DEFINES parameters in qmake
> -- CONFIG+"no-bundled-speex" no additional comment. should be clear
> you can find more infos in the mumble wiki
As I said before I need to use no-g15 too cause I didn't found dependency for
it on F9(witch I'm using now till F11 comes out).

> some configs would be problematical in different fedoraversions. like
> pulseaudioparameters.
> you should create seperate configstrings for these and seperate it with
> different if "instructions"
> examples:
> %if 0%{?fedora_version} = 9
> CONFIG+"no-bundled-speex no-pulseaudio no-oss"
> %endif
> %if 0%{?fedora_version} = 10
> CONFIG+"no-bundled-speex no-pulseaudio"
> %endif
> %if 0%{?fedora_version} >= 11
> CONFIG+"no-bundled-speex"
> %endif
Don't see the reason why would it be problematic? Pulseaudio works on F9(using
it right now with mumble).


> 
> - install all pixmaps and all icons
> you can find it in the "icons" directory
This part I can't understand. To witch directory should I install icons and
how? How to choose witch icon will mumble use? There are many icons dirs and I
get lost. I couldn't find anything in wiki that would help me.

> 
> - install all mumble plugins (seperate subopackage(s))
> -- work with PLUGIN_PATH - a DEFINES parameter
Can you explain this a little bit more? Should I make another package like I
did with murmur. 
%package -n mumble-plugins


> 
> - murmurd should be installed in sbin
Done

> 
> - add the attached initfile as seperate source, like Source1
Done

> 
> - add overlay (seperate subpackage)
> you can find it in the "scripts" directory
Same as above:
Can you explain this a little bit more? Should I make another package like I
did with murmur. 
%package -n mumble-overlay


> -- add a desktopfile for mumble overlay
> add it as seperate source, like Source2
Should I create desktop file?

> 
> - you need to honor optflags
> QMAKE_CFLAGS_RELEASE="%{optflags}"
> QMAKE_CXXFLAGS_RELEASE="%{optflags}"
If i do:
make %{optflags}
it throws me an error. Really big one. Would be hard to read if I post it here.
Here is the link: 
http://78.46.84.75:81/tj/etmain/mumble.error
Compiling works with only make


Here is the new spec file: http://78.46.84.75:81/tj/etmain/mumble.spec

Currently spec file throws error cause installation isn't working but I want to
be sure that I'm going to right direction with installation.

Greetz,
Igor

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.