[Bug 497593] Review Request: gnome-alsamixer - advanced mixer for GNOME

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497593





--- Comment #16 from Andreas Thienemann <andreas at bawue.net>  2009-04-25 08:02:04 EDT ---
(In reply to comment #14)


> Please don't use %makeinstall, see
> https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

As discussed on IRC: make DESTDIR doesn't work, I checked.
Patching the makefile would be an option, but using %makeinstall does work as
expected. If the maintainer wants to patch the Makefile to make DESTDIR work,
that is fine. I'd leave it to his discretion.
It's not a blocker as is.

> Inline desktop file creation ws forbidden recently, see
> https://fedoraproject.org/wiki/Packaging/Guidelines#.desktop_file_creation

The wiki does state "You can do this by including a .desktop file you create as
a Source: (e.g. Source3: %{name}.desktop) or generating it in the spec file."

As you mentioned on IRC, there seems to have been a mail somewhere stating
this. So even though it seems not (yet) to be official policy, I've attached a
patch fixing this potential future problem. 

> rpmbuild --rebuild does not work for F-10, see http://fpaste.org/paste/10125  

Old file. That was already fixed.
http://adamwill.fedorapeople.org/gnome-alsamixer/gnome-alsamixer-0.9.7-0.1.20090424gitc540b26.fc10.src.rpm
was the last submission from packager and does not exhibit that problem.
Not a blocker.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.